Refactor code structure #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please review this pr? @lazorfuzz |
lazorfuzz
reviewed
May 17, 2024
src/index.js
Outdated
| @@ -23,7 +24,7 @@ const middleware = async (req, res, next) => { | |||
| switch (req.path) { | |||
| case heapWebPath: | |||
| try { | |||
| await heap(heapFilePath); | |||
| await heap(heapFilePath, pprof); | |||
There was a problem hiding this comment.
Why pass the module as a param?
There was a problem hiding this comment.
@lazorfuzz Passing the pprof instance to both the heap and wall modules ensures they share the same instance, guaranteeing consistency and avoiding potential issues that may arise from using different instances of pprof.
There was a problem hiding this comment.
Hey @lazorfuzz can you review this PR and give some suggestion / feedback?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code structure