Revise Dockerfiles to use caching #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickdemers6
force-pushed
the
35-integration-speed
branch
from
ea24db9
to
b18d30a
Compare
patrickdemers6
force-pushed
the
35-integration-speed
branch
from
b18d30a
to
bc3941c
Compare
aaronpkahn
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the Dockerfiles to improve the use caching.
Dependencies are loaded prior to pulling in source code. I have also moved building the binary to the
test/integration/Dockerfile. Then, the rootDockerfilecan pull the binary from tagged image. This prevents needing to load dependencies twice.Before
make integrationtakes 2 minutes 15 seconds on every build.After
make integrationtakes 58 seconds on all builds, unless there are changes togo.modorgo.sum.That's some Plaid acceleration!
Side note: This makes use of BuildKit which replaces the legacy builder. It is the default builder in latest Docker version. This will still work for users not on latest Docker version as the environment variable
DOCKER_BUILDKITis set.Closes #35