-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barcode scanner does not work in some android devices #465
Conversation
Hello Devs, Please take a look in this PR. With a simple upgrade in com.google.mlkit:barcode-scanning version 17.0.1 will fix a serious bug in bar code reader for modern android devices with 3 cameras (Motorola Moto G9 Play, camera: 48 Mp + 2 Mp + 2 Mp ). It don't result in any conflict therefore it will be important to accept it deploy to production. |
I'm facing the same situation on motorola moto g(9) play, I used this adjustment and it worked, I would like to know when the merge with the project master will be done. |
Hello, please someone could approve this PR? |
Hello, I used this fix on production and I can confirm it works! |
Thank you for the PR, @cassioseffrin and thank you @Freddy03h for testing it. Merged. |
At this point, the bundling version has changed. |
Thanks @JaewonKim81 - it was updated to .2 in the r/13.0.0 branch |
Thks @scarlac! By the way, did you have an estimative when the master branch will be deployed to npmjs.com. The current last version available on npmjs is 12.1.0. |
hello, I would also like to know when the master branch will be deployed on npmjs.com. The latest current version available on npmjs is 12.1.0. |
This change was included with v13.0.0 which was just release. Att @cassioseffrin and @lucasfiametti |
thank you so much @scarlac |
implementation 'com.google.mlkit:barcode-scanning:17.0.2' |
@shubhamraiy, Try to see the errors with logcat: I don't think com.google.mlkit:barcode-scanning:17.0.2 could cause any crashes by itself. We have tested in several real devices with no crashes. May it can be related with some another RN library of your project or even some issue with android studio project. |
@shubhamraiy We are using the version 13 already available on npmjs: https://www.npmjs.com/package/react-native-camera-kit/v/13.0.0 15 days ago. Everything is fine, no bugs. If you have a particular issue please try to put errors here (use logcat for more low level infos). You also could use an older version of this library case it works for your project. |
Summary
How did you test this change?
I have tested it in real devices (ios and android). The issue was related to the implementation of com.google.mlkit:barcode-scanning. The current master version was upgraded from 16.0.3 to 17.0.1.