Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barcode scanner does not work in some android devices #465

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

cassioseffrin
Copy link
Contributor

Summary

How did you test this change?

I have tested it in real devices (ios and android). The issue was related to the implementation of com.google.mlkit:barcode-scanning. The current master version was upgraded from 16.0.3 to 17.0.1.

@cassioseffrin cassioseffrin changed the title Varcode scanner does not work in some android devices Barcode scanner does not work in some android devices May 6, 2022
@cassioseffrin
Copy link
Contributor Author

Hello Devs,

Please take a look in this PR. With a simple upgrade in com.google.mlkit:barcode-scanning version 17.0.1 will fix a serious bug in bar code reader for modern android devices with 3 cameras (Motorola Moto G9 Play, camera: 48 Mp + 2 Mp + 2 Mp ). It don't result in any conflict therefore it will be important to accept it deploy to production.

@lucasfiametti
Copy link

I'm facing the same situation on motorola moto g(9) play, I used this adjustment and it worked, I would like to know when the merge with the project master will be done.

@cassioseffrin
Copy link
Contributor Author

Hello, please someone could approve this PR?

@Freddy03h
Copy link

Hello, I used this fix on production and I can confirm it works!

@scarlac scarlac merged commit 1de4ed4 into teslamotors:master Aug 7, 2022
@scarlac
Copy link
Collaborator

scarlac commented Aug 7, 2022

Thank you for the PR, @cassioseffrin and thank you @Freddy03h for testing it. Merged.

@JaewonKim81
Copy link

At this point, the bundling version has changed.
implementation 'com.google.mlkit:barcode-scanning:17.0.2'

@scarlac
Copy link
Collaborator

scarlac commented Aug 9, 2022

Thanks @JaewonKim81 - it was updated to .2 in the r/13.0.0 branch

@cassioseffrin
Copy link
Contributor Author

Thks @scarlac! By the way, did you have an estimative when the master branch will be deployed to npmjs.com. The current last version available on npmjs is 12.1.0.

@lucasfiametti
Copy link

hello, I would also like to know when the master branch will be deployed on npmjs.com. The latest current version available on npmjs is 12.1.0.

@scarlac
Copy link
Collaborator

scarlac commented Aug 29, 2022

This change was included with v13.0.0 which was just release. Att @cassioseffrin and @lucasfiametti

@lucasfiametti
Copy link

thank you so much @scarlac

@shubhamraiy
Copy link

implementation 'com.google.mlkit:barcode-scanning:17.0.2'
App is crashing after using this line. Please help me out of this.

@hermanorigotto
Copy link

@shubhamraiy, Try to see the errors with logcat:
adb logcat *:E

I don't think com.google.mlkit:barcode-scanning:17.0.2 could cause any crashes by itself. We have tested in several real devices with no crashes. May it can be related with some another RN library of your project or even some issue with android studio project.

@cassioseffrin
Copy link
Contributor Author

cassioseffrin commented Sep 14, 2022

@shubhamraiy We are using the version 13 already available on npmjs: https://www.npmjs.com/package/react-native-camera-kit/v/13.0.0 15 days ago. Everything is fine, no bugs.

If you have a particular issue please try to put errors here (use logcat for more low level infos). You also could use an older version of this library case it works for your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants