Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting error #570

Merged
merged 1 commit into from Aug 14, 2023
Merged

Fix linting error #570

merged 1 commit into from Aug 14, 2023

Conversation

DavidBertet
Copy link
Contributor

  • java.lang.Iterable#forEach requires minSdkVersion 24
  • defaultConfig > targetSdkVersion 30 should be overridden by parent app, disable the error as it is Play Store specific

Summary

Issue raised by #566

Running the linter on example project

./example/android/gradlew lintDebug

raises 3 errors on the library itself

  • java.lang.Iterable#forEach requires minSdkVersion 24
    • in rectBounds.forEach
    • in barcodes.forEach
  • targetSdkVersion must be higher than 31 for the Google Play Store

Fix

  • Bump minSdkVersion from 23 to 24
  • Silent ExpiredTargetSdkVersion in the library because the parent app is setting their own. As it is a Google Play Store, someone using it on a private store would be fine
    • Is it needed to specify it at all on the library? Not sure

How did you test this change?

No more linting error. It shouldn't impact the project as minSdkVersion doesn't do much.

- java.lang.Iterable#forEach requires minSdkVersion 24
- defaultConfig > targetSdkVersion 30 should be overridden by parent app, disable the error as it is Play Store specific
@scarlac scarlac merged commit 91915bf into teslamotors:master Aug 14, 2023
3 checks passed
@DavidBertet DavidBertet deleted the fix/lint_error branch August 15, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants