Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

FullHierarchy search enhancement #404

Merged
merged 1 commit into from
Aug 28, 2020
Merged

FullHierarchy search enhancement #404

merged 1 commit into from
Aug 28, 2020

Conversation

AndrewRAM33
Copy link
Contributor

@AndrewRAM33 AndrewRAM33 commented Aug 17, 2020

FullHierarchy search enhancement (#403).

Feature
New FullHierarchy widget meta option:

hierarchyDisableDescendants?: boolean

Means that FullHierarchy search result should not include descendants of found elements.

Bug fix
<FilterPopup> component should not do bcForceUpdate when a filter is applied or cleared on a FullHierarchy.

Bug fix
Data epic did not transfer filters param for FullHierarchy backend query. sorters parameters unchanged.

@AndrewRAM33 AndrewRAM33 added bug Something isn't working enhancement New feature or request labels Aug 17, 2020
@AndrewRAM33 AndrewRAM33 force-pushed the fix/issue-403 branch 3 times, most recently from e9582f3 to abcb503 Compare August 19, 2020 09:14
@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2020

Pull Request Test Coverage Report for Build 216742366

  • 7 of 11 (63.64%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 37.8%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/FullHierarchyTable/utils/useExpandedKeys.ts 0 2 0.0%
src/epics/data.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/epics/data.ts 1 3.74%
Totals Coverage Status
Change from base Build 215253267: 0.03%
Covered Lines: 1764
Relevant Lines: 3773

💛 - Coveralls

@AndrewRAM33 AndrewRAM33 marked this pull request as ready for review August 19, 2020 09:23
@AndrewRAM33 AndrewRAM33 force-pushed the fix/issue-403 branch 2 times, most recently from 09becd0 to 68b88c6 Compare August 19, 2020 10:04
AndrewRAM33 added a commit that referenced this pull request Aug 20, 2020
@AndrewRAM33 AndrewRAM33 mentioned this pull request Aug 20, 2020
AndrewRAM33 added a commit that referenced this pull request Aug 25, 2020
sergromanov4 pushed a commit that referenced this pull request Aug 26, 2020
sergromanov4 pushed a commit that referenced this pull request Aug 26, 2020
AndrewRAM33 added a commit that referenced this pull request Aug 27, 2020
AndrewRAM33 added a commit that referenced this pull request Aug 27, 2020
@Dergash Dergash added this to the 1.20.0 milestone Aug 28, 2020
@Dergash Dergash merged commit f79ba3d into develop Aug 28, 2020
@Dergash Dergash deleted the fix/issue-403 branch August 28, 2020 04:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants