#methodComments is a strang method... it returns all comments at the …

…level of the method, but including comments on arguments. There are no clients. It is not clear why this is needed as an API method.
tesonep · Jul 10, 2020 · 4cc1c32 · 4cc1c32
1 parent a2ba9b1
commit 4cc1c32
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 23 deletions.
diff --git a/src/AST-Core/RBMethodNode.class.st b/src/AST-Core/RBMethodNode.class.st
@@ -472,14 +472,6 @@ RBMethodNode >> methodClass: aClass [
 	self compilationContext class: aClass
 ]
 
-{ #category : #accessing }
-RBMethodNode >> methodComments [
-	| methodComments |
-	methodComments := OrderedCollection withAll: self comments.
-	arguments do: [:each | methodComments addAll: each comments].
-	^methodComments asSortedCollection: [:a :b | a start < b start]
-]
-
 { #category : #accessing }
 RBMethodNode >> methodNode [
 	^self

diff --git a/src/AST-Core/RBProgramNode.class.st b/src/AST-Core/RBProgramNode.class.st
@@ -655,11 +655,6 @@ RBProgramNode >> matchList: matchNodes index: matchIndex against: programNodes i
 		inContext: aDictionary
 ]
 
-{ #category : #accessing }
-RBProgramNode >> methodComments [
-	^self comments
-]
-
 { #category : #accessing }
 RBProgramNode >> methodNode [
 	^parent ifNotNil: [parent methodNode]

diff --git a/src/AST-Core/RBSequenceNode.class.st b/src/AST-Core/RBSequenceNode.class.st
@@ -358,16 +358,6 @@ RBSequenceNode >> match: aNode inContext: aDictionary [
 					inContext: aDictionary]
 ]
 
-{ #category : #accessing }
-RBSequenceNode >> methodComments [
-	| methodComments |
-	methodComments := OrderedCollection withAll: self comments.
-	temporaries do: [:each | methodComments addAll: each comments].
-	(parent notNil and: [parent isBlock]) 
-		ifTrue: [parent arguments do: [:each | methodComments addAll: each comments]].
-	^methodComments asSortedCollection: [:a :b | a start < b start]
-]
-
 { #category : #'accessing-token' }
 RBSequenceNode >> periods [
 	^ periods

diff --git a/src/Deprecated90/RBMethodNode.extension.st b/src/Deprecated90/RBMethodNode.extension.st
@@ -1,5 +1,14 @@
 Extension { #name : #RBMethodNode }
 
+{ #category : #'*Deprecated90' }
+RBMethodNode >> methodComments [
+	| methodComments |
+	self deprecated: 'no users, will be removed in Pharo10'.
+	methodComments := OrderedCollection withAll: self comments.
+	arguments do: [:each | methodComments addAll: each comments].
+	^methodComments asSortedCollection: [:a :b | a start < b start]
+]
+
 { #category : #'*Deprecated90' }
 RBMethodNode >> primitiveSources [
 	self deprecated: 'please use the #pragmas directly'.

diff --git a/src/Deprecated90/RBProgramNode.extension.st b/src/Deprecated90/RBProgramNode.extension.st
@@ -0,0 +1,9 @@
+Extension { #name : #RBProgramNode }
+
+{ #category : #'*Deprecated90' }
+RBProgramNode >> methodComments [
+	self
+		deprecated: 'Please use #comments instead'
+		transformWith: '`@receiver methodComments' -> '`@receiver comments'.
+	^self comments
+]
diff --git a/src/Deprecated90/RBSequenceNode.extension.st b/src/Deprecated90/RBSequenceNode.extension.st
@@ -0,0 +1,12 @@
+Extension { #name : #RBSequenceNode }
+
+{ #category : #'*Deprecated90' }
+RBSequenceNode >> methodComments [
+	| methodComments |
+	self deprecated: 'no users, will be removed in Pharo10'.
+	methodComments := OrderedCollection withAll: self comments.
+	temporaries do: [:each | methodComments addAll: each comments].
+	(parent notNil and: [parent isBlock]) 
+		ifTrue: [parent arguments do: [:each | methodComments addAll: each comments]].
+	^methodComments asSortedCollection: [:a :b | a start < b start]
+]