ChangeSet>>#methodsWithoutComments was using #firstPrecodeCommentFor:…

… just for testing if the method has a comment. It is much nicer to add a method that checks if a method has a method comment and use that. This way we can easily deprecate #firstPrecodeCommentFor: later
tesonep · Jun 10, 2020 · c3598fe · c3598fe
1 parent 32d237b
commit c3598fe
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/Kernel-Tests-Extended/CompiledMethodTest.class.st b/src/Kernel-Tests-Extended/CompiledMethodTest.class.st
@@ -405,6 +405,11 @@ CompiledMethodTest >> testEqualityInstanceSideMethod [
 	self assert: method1 equals: method2
 ]
 
+{ #category : #'tests - testing' }
+CompiledMethodTest >> testHasComment [
+	self assert: (CompiledMethod>>#hasComment) hasComment
+]
+
 { #category : #'tests - instance variable' }
 CompiledMethodTest >> testHasInstVarRef [
 

diff --git a/src/Kernel/CompiledMethod.class.st b/src/Kernel/CompiledMethod.class.st
@@ -448,6 +448,12 @@ CompiledMethod >> getSourceReplacingSelectorWith: newSelector [
 	^newSource
 ]
 
+{ #category : #testing }
+CompiledMethod >> hasComment [
+	"check if this method has a method comment"
+	^self comment isEmptyOrNil not
+]
+
 { #category : #'accessing-pragmas & properties' }
 CompiledMethod >> hasPragmaNamed: aSymbol [
 	^ self pragmas anySatisfy: [ :pragma | pragma selector = aSymbol ]

diff --git a/src/System-Changes/ChangeSet.class.st b/src/System-Changes/ChangeSet.class.st
@@ -1206,7 +1206,7 @@ ChangeSet >> methodsWithoutComments [
 		(self methodChangesAtClass: aClass name) associationsDo: 
 				[:mAssoc | (#(remove addedThenRemoved) includes: mAssoc value) ifFalse:
 					[(aClass includesSelector:  mAssoc key) ifTrue:
-						[(aClass firstPrecodeCommentFor: mAssoc key) isEmptyOrNil
+						[(aClass>>mAssoc key) hasComment
 								ifTrue: [slips add: aClass name , ' ' , mAssoc key]]]]].
 	^ slips