Infinite Loop on Express Test

[johnnyman727]

See my comment regarding the Express test in the colony test suite.

[kevinswiber]

It may have to do with having both a split and replace with regular expressions on the same line.

See here: https://github.com/broofa/node-mime/blob/48cbcf979b4d1980098217e275f03da33a311c5e/mime.js#L59

var fields = line.replace(/\s*#.*|^\s*|\s*$/g, '').split(/\s+/);

[kevinswiber]

Ah, scratch that. Looks like everything's like getting properly broken into an AST at some point.

There's something unfriendly about the expression itself, I think.

[kevinswiber]

Currently Googling "JavaScript compatible regular expression C library" with a stern look on my face. :/

I'm hoping the issue is easier to solve than that.

[kevinswiber]

Sorry for the tweet-style issue commenting. If it does come down to needing a regex engine that's JavaScript compatible... I just remembered a project called Duktape. They have a regex engine.

Site: http://duktape.org
Code: https://github.com/svaarala/duktape/tree/master/src

That may be an option.

[kevinswiber]

Okay... confirmed this doesn't work in colony, though I didn't try using hsregex directly.

console.log('Hello World'.replace(/\s|l*/g, ''));

In colony, that's an infinite loop.

In Node, it's "HeoWord".

And for the record, it also appears to work properly in Duktape. Here's the gist I used to test it: https://gist.github.com/kevinswiber/d04bd75725713d42eec2

[kevinswiber]

As you can read in the description of the issue linked below, I need an independent, JavaScript-compatible regular expression parser for my own needs, but if you were interested in using Duktape's implementation, as well, the author gives some advice here: svaarala/duktape#12 (comment)

Provided I get the time to attempt this, I can always circle back around to Tessel at a later date and see if it plugs in to the runtime nicely. Otherwise, there's likely a quicker fix for this specific issue.

[kevinswiber]

I think #113 fixes this issue of the infinite loop. However, the express sample is still not running. More info being added to #110.

[kevinswiber]

The mime module is trying to split its data file contents by line using this regular expression: [\r\n]+. The result of the split is wacky and breaks the module, thereby breaking the Content-Type header returned by Express.

More details here: #110 (comment)

[johnnyman727]

Just as an update to anyone watching this issue, the Express test no longer goes into an infinite loop but it does not parse paths correctly.

[kevinswiber]

This is related to #108. Trouble line: https://github.com/expressjs/parseurl/blob/master/index.js#L17

[johnnyman727]

Express is hitting some other compat issues. Currently, upon require:

➜  sandbox  tessel run server.js
TESSEL! Connected to TM-00-04-f000da30-005d4344-60782586.
INFO Bundling directory /Users/Jon/Work/technical/sandbox (~710.25 KB)
INFO Deploying bundle (1.13 MB)...
INFO Running script...
[T]: src/colony/lua/colony-js.lua:906: bad argument #2 to 'f' (number expected, got nil)

I'm going to close this issue in favor of more specific Node/JS compat issues.