Ipv6 link local fix (#702)

* Detect ipv6 addresses and append the network interface when connecting

* Make sure this.ip is a thing before trying to determine if the network interface needs to be appended

* Added unit tests, changed indexOf to includes (thanks @rwaldron)

* Added comments to the tests

* added expect(x) calls to tests

* Idiot forgot he wasn't using phpunit

lib/lan-connection.js

@@ -25,6 +25,9 @@ var LAN = {};
 LAN.Connection = function(opts) {
   this.auth = {};
   this.ip = Array.isArray(opts.addresses) ? opts.addresses[0] : opts.host;
+  if (this.ip && this.ip.includes(':') && opts.networkInterface) {
+    this.ip = `${this.ip}%${opts.networkInterface}`;
+  }
   this.host = opts.host || '';
   this.auth.host = this.ip;
   this.auth.port = opts.port || 22;

test/unit/lan-connection.js

@@ -21,6 +21,52 @@ exports['LAN.Connection'] = {
     test.equal(this.lanConnection.connectionType, 'LAN');
     test.done();
   },
+
+  ipWhenIpV6: function(test) {
+    test.expect(1);
+    this.lanConnection = new LAN.Connection({
+      addresses: ['fc00::', '172.16.2.5'],
+      host: 'home.loc',
+    });
+    // The first address was picked
+    test.equal(this.lanConnection.ip, 'fc00::');
+    test.done();
+  },
+
+  ipWhenIpV6LinkLocal: function(test) {
+    test.expect(1);
+    this.lanConnection = new LAN.Connection({
+      addresses: ['fc00::', '172.16.2.5'],
+      networkInterface: 'en0',
+      host: 'home.loc',
+    });
+    // THe first address was picked, which was ipv6, and a network interface also provided
+    test.equal(this.lanConnection.ip, 'fc00::%en0');
+    test.done();
+  },
+
+  ipWhenIpV4: function(test) {
+    test.expect(1);
+    this.lanConnection = new LAN.Connection({
+      addresses: ['172.16.2.5', 'fc00::'],
+      networkInterface: 'en0',
+      host: 'home.loc',
+    });
+    // The first address was picked
+    test.equal(this.lanConnection.ip, '172.16.2.5');
+    test.done();
+  },
+
+  // no ip addresses were found, fallback to the host
+  ipWhenNoIps: function(test) {
+    test.expect(1);
+    this.lanConnection = new LAN.Connection({
+      networkInterface: 'en0',
+      host: 'home.loc',
+    });
+    test.equal(this.lanConnection.ip, 'home.loc');
+    test.done();
+  },
 };
 
 exports['LAN.Scanner'] = {