t2 run: temporary restriction to remote process stdin forwarding (LAN…

… only)

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>

lib/tessel/deploy.js

@@ -383,9 +383,11 @@ exportables.run = function(tessel, opts) {
           // When the stream closes, return from the function
           remoteProcess.once('close', resolve);
 
-          // Pipe input TO the remote process.
-          process.stdin.pipe(remoteProcess.stdin);
-          process.stdin.setRawMode(true);
+          if (tessel.connection.connectionType === 'LAN') {
+            // Pipe input TO the remote process.
+            process.stdin.pipe(remoteProcess.stdin);
+            process.stdin.setRawMode(true);
+          }
 
           // Pipe output FROM the remote process.
           remoteProcess.stdout.pipe(process.stdout);

package.json

@@ -31,6 +31,7 @@
   },
   "homepage": "https://github.com/tessel/t2-cli",
   "devDependencies": {
+    "coveralls": "^2.11.9",
     "grunt": "^0.4.5",
     "grunt-cli": "^0.1.13",
     "grunt-contrib-jshint": "^0.11.2",

test/unit/deploy.js

@@ -523,9 +523,11 @@ exports['deploy.run'] = {
     });
   },
 
-  runStdInOut: function(test) {
+  runStdInOutLan: function(test) {
     test.expect(4);
 
+    this.tessel.connection.connectionType = 'LAN';
+
     this.exec = sandbox.stub(this.tessel.connection, 'exec', (command, options, callback) => {
       callback(null, this.tessel._rps);
       this.tessel._rps.emit('close');
@@ -545,6 +547,30 @@ exports['deploy.run'] = {
       test.done();
     });
   },
+
+  runStdInOutUsb: function(test) {
+    test.expect(2);
+
+    this.tessel.connection.connectionType = 'USB';
+
+    this.exec = sandbox.stub(this.tessel.connection, 'exec', (command, options, callback) => {
+      callback(null, this.tessel._rps);
+      this.tessel._rps.emit('close');
+    });
+
+    this.stdinPipe = sandbox.stub(process.stdin, 'pipe');
+    this.stdinSetRawMode = sandbox.stub(process.stdin, 'setRawMode');
+
+    deploy.run(this.tessel, {
+      resolvedEntryPoint: 'foo',
+      lang: deployment.js,
+    }).then(() => {
+      test.equal(this.stdinPipe.callCount, 0);
+      test.equal(this.stdinSetRawMode.callCount, 0);
+      test.done();
+    });
+  },
+
 };
 
 exports['deploy.createShellScript'] = {