Skip to content

Commit

Permalink
Rewords binary compilation warning. (#992)
Browse files Browse the repository at this point in the history
  • Loading branch information
tcr authored and rwaldron committed Sep 21, 2016
1 parent 1079bf3 commit f72da03
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions lib/tessel/deployment/javascript.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,18 @@ exportables.postRun = function(tessel, options) {
return Promise.resolve();
};

exportables.logMissingBinaryModuleWarning = function(name) {
exportables.logMissingBinaryModuleWarning = function(name, version) {
var warning = tags.stripIndent `
Pre-compiled module is missing: ${name}.
This might be caused by any of the following:
Pre-compiled module is missing: ${name}@${version}.
Please an file issue at https://github.com/tessel/t2-cli/issues/new with this warning.
1. The binary is platform specific and cannot be compiled for OpenWRT.
2. A pre-compiled binary has not yet been generated for this module.
3. The binary didn't compile correctly for the platform that you're developing on.
It's possible that the binary is Linux-only or even OpenWRT specific,
try npm installing with "--force" and rerun your deployment command.
This warning might be caused by one of the following:
Please file an issue at https://github.com/tessel/t2-cli/issues/new
1. A pre-compiled binary has not yet been built for this module.
2. The binary didn't compile correctly for the platform that you're developing on.
Binaries that are Linux-only or even OpenWRT-specific may cause this issue.
Try to npm install --force the affected module, then rerun your deployment command.
3. The binary may be platform specific and impossible to compile for OpenWRT.
`;

log.warn(warning.trim());
Expand Down Expand Up @@ -388,7 +388,7 @@ exportables.injectBinaryModules = function(globRoot, tempBundlePath, options) {
} else {
// In the future we may allow users to log the ignored modules here
if (!details.ignored) {
exportables.logMissingBinaryModuleWarning(details.name);
exportables.logMissingBinaryModuleWarning(details.name, details.version);
}
}
});
Expand Down

0 comments on commit f72da03

Please sign in to comment.