Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended settings for uglify.minify() #1261

Closed
rwaldron opened this issue Jun 28, 2017 · 2 comments
Closed

Recommended settings for uglify.minify() #1261

rwaldron opened this issue Jun 28, 2017 · 2 comments
Assignees

Comments

@rwaldron
Copy link
Contributor

In mishoo/UglifyJS#968 (comment), @kzc recommends adding the following settings for even more code reduction wins:

    compress: {
        ecma: 6,
        passes: 3,
        pure_getters: true,
        // other existing options
    },
    output: {
        ecma: 6,
        // other existing options
    },

I think pure_getters might be problematic, but still worth trying!

@rwaldron rwaldron self-assigned this Jun 28, 2017
rwaldron added a commit that referenced this issue Jun 28, 2017
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
@rwaldron
Copy link
Contributor Author

We landed this

@kzc
Copy link

kzc commented Jun 30, 2017

@rwaldron Did you see any deploy size reduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants