Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inquirer might be more appropriate than terminal-menu #355

Closed
rwaldron opened this issue Oct 1, 2015 · 1 comment
Closed

inquirer might be more appropriate than terminal-menu #355

rwaldron opened this issue Oct 1, 2015 · 1 comment
Assignees
@rwaldron

Comments

@rwaldron
Copy link
Contributor

rwaldron commented Oct 1, 2015

I'm going to investigate.

https://www.npmjs.com/package/inquirer
@rwaldron rwaldron self-assigned this Oct 1, 2015
@rwaldron
Copy link
Contributor Author

rwaldron commented Oct 1, 2015

particle-cli uses inquirer, this is what a "select from list" experience looks like, vs current t2-cli:

Problems:

  • The UI change (colored background, colored text) is disorienting
  • The loss of previously printed stdout is confusing (no indication of what steps were reported before the prompt)

As shown in the inquirer example above, lists can be displayed inline.

Here is the same functionality, using inquirer:

rwaldron added a commit to rwaldron/t2-cli that referenced this issue Oct 1, 2015
@rwaldron
Refactor controller.menu (Replace terminal-menu with inquirer.prompt). …
6b40f55 
…Closes tesselgh-355
@rwaldron rwaldron mentioned this issue Oct 1, 2015
Merged
rwaldron added a commit to rwaldron/t2-cli that referenced this issue Oct 1, 2015
@rwaldron
Refactor controller.menu (Replace terminal-menu with inquirer.prompt). …
77bd7e0 
…Closes tesselgh-355
rwaldron added a commit that referenced this issue Oct 4, 2015
@rwaldron
Merge pull request #357 from rwaldron/inquirer
2cd3a6c 
Refactor controller.menu (Replace terminal-menu with inquirer.prompt). Closes gh-355
rwaldron added a commit that referenced this issue Oct 5, 2015
@rwaldron
Merge branch 'master' into jon-fix-erase
059bff3 
* master:
  Reject the heuristics promise instead of returning nothing
  Fix hueristics and add tests
  Adds missing package json fields
  Automatically resolves wifi info so no Tessel is fetched
  Add neutral wifi command to list Tessel Wifi Information
  Uses LAN and USB flags properly
  Fix a unit test to make Grunt happy
  Match t2 list formatting.
  Refactor controller.menu (Replace terminal-menu with inquirer.prompt). Closes gh-355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwaldron rwaldron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwaldron