Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax Error detection is wrong #583

Closed
rwaldron opened this issue Feb 19, 2016 · 0 comments
Closed

Syntax Error detection is wrong #583

rwaldron opened this issue Feb 19, 2016 · 0 comments

Comments

@rwaldron
Copy link
Contributor

Patch to follow.
rwaldron added a commit to rwaldron/t2-cli that referenced this issue Feb 19, 2016
@rwaldron
Corrections to syntax error handling in compress operation. Fixes tes…
61ef284 
…selgh-583

The correc algorithm:

1. Let ast be a.parse(source)
2. If ast is a syntax error (e), let m be e.message
    1. Set the value of ast to u.parse(source)
        1. If ast is a syntax error (e), append e.message to m.
            1. throw new SyntaxError(m)
johnnyman727 added a commit that referenced this issue Feb 20, 2016
@johnnyman727
Merge pull request #584 from rwaldron/583
da5d651 
Corrections to syntax error handling in compress operation. Fixes gh-583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwaldron