Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t2 update: remote updatePath should not be created with path.join(...) #632

Closed
rwaldron opened this issue Apr 2, 2016 · 1 comment
Closed

Comments

@rwaldron
Copy link
Contributor

rwaldron commented Apr 2, 2016

This:

var updatePath = path.join('/tmp/', updates.OPENWRT_BINARY_FILE);

Is fine on *nix platforms, because the remote path will have the same structure, ie. forward slash delimiters. When updating from a windows machine, this will result in a windows normalized path (I will post an example directly from my windows machine as soon as I post this)

@rwaldron
Copy link
Contributor Author

rwaldron commented Apr 2, 2016

Rick@Rick-PC MINGW64 ~
$ node
> path.join("/tmp/", "other");
'\\tmp\\other'

rwaldron added a commit to rwaldron/t2-cli that referenced this issue Apr 2, 2016
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
tikurahul pushed a commit to tikurahul/t2-cli that referenced this issue Apr 10, 2016
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant