[restart] t2 restart is broken

[johnnyman727]

t2 restart returns:

➜  ambient-attx4 git:(master) t2 restart
INFO Looking for your Tessel...
INFO Connected to Tessel-02A3BBAD6C82.
INFO Running undefined...
module.js:339
    throw err;
    ^

Error: Cannot find module '/tmp/remote-script/undefined'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Function.Module.runMain (module.js:467:10)
    at startup (node.js:134:18)
    at node.js:961:3

We need some better unit tests as well.

[johnnyman727]

I haven't been able to make a `reproducible test case for the error message described above, but I did find an unaddressed corner case. My directory structure looks like

ambient-attx4
--debug
----update.js
--node_modules
--index.js
--OTHER_STUFF

If I run t2 run debug/update.js, and then run t2 restart, it will not run the script I previously ran because it delegates to Node to determine the entrypoint for the file which will not be the script I just ran. Not sure if we can fix this case though.

[johnnyman727]

Okay, steps to reproduce the first error message are simple:

t2 init
t2 run index.js
^C after lights start blinking
t2 restart
[FAILURE]

[rwaldron]

I've never seen t2 restart without an entry point, ie. t2 restart index.js. How is t2 restart supposed to know which file to start with from one run to another?

[rwaldron]

The real bug is that it allows you to get that far without displaying an error

[rwaldron]

In addition to my previous two comments, I'm actually seeing another issue: there is no package.json, which is what gets used to determine what to run when you type t2 restart with no entry point (I had actually forgotten about this.)

If I run t2 run debug/update.js, and then run t2 restart, it will not run the script I previously ran because it delegates to Node to determine the entrypoint for the file which will not be the script I just ran. Not sure if we can fix this case though.

Not without writing some state, which we can do, but it's new territory.

[rwaldron]

TBH, looking in the package.json is probably too much of an assumption and I think we should drop that fallback.