Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t2 root #80

Closed
Frijol opened this issue May 4, 2015 · 9 comments
Closed

t2 root #80

Frijol opened this issue May 4, 2015 · 9 comments

Comments

@Frijol
Copy link
Member

Frijol commented May 4, 2015

Current status: no such command

Spec: T2 CLI spec
tessel root [-i ]

Provides access to the underlying Linux system running on Tessel 2: exactly SSH (copies regular SSH keys to authorize and SSHes in as Linux computer)

$ tessel root --help
> Usage: tessel root [-i <path>] [--help]
>  -i <path>:   provide a path to the desired ssh key
$ 

$ tessel root
> Accessing root...
root@192.168.128.124 # 
@Frijol Frijol added the spec-cli label May 4, 2015
@Frijol Frijol mentioned this issue May 4, 2015
15 tasks
@nplus11
Copy link
Contributor

nplus11 commented May 5, 2015

I recommend that -i option be called -k|--keypath in order to stay consistent with our new tessel remote command.

@johnnyman727
Copy link
Contributor

Actually, we should probably just change the other API since -i is the standard. Thanks for catching that!

@Student007
Copy link
Member

@johnnyman727 assign it to me - I have figured out this successfully. Next days I will do a pull request after I wrote tests for MacOSX, Windows, Linux behaviors and cleaning up my code.

@Student007
Copy link
Member

@johnnyman727 I haven't done writing test now. But cleaning up code is done. So I made a brunch "t2 root" you could take a preview. It isn't tested on Windows or Linux - only MacOSX. I have to stop for today. Tomorrow I plan to start writing tests ... but family ... weekend .. surprisings ...

@johnnyman727
Copy link
Contributor

@Student007 It's a bit hard to look over the changes on your fork b/c it's spread across to many different repos. Could you squash your commits and open a PR on this repo? I'm happy to review it!

@Student007
Copy link
Member

@johnnyman727 yes of cause - when tests are written. I had gone on vacation last few days. The note about the branch was meant about to have a first look how I solved the task. So you could say "no ... not that way" or ... "fitting solution". git clone https://github.com/Student007/t2-cli.git --branch t2-root --single-branch ... than test it with several numbers of (not) authorized LAN Tessels.
If only one Tessel is out there, it connects directly - if there found more Tessels it provides a Menu-Navigation (ncurses like). It could be more improved by a much more powerful JavaScript reimplementation of ncurses (e.g.) and also additional information like CPU/Memory usage of each found Tessel, but I like to finish testing before. I have only used Mocha and my own Test-Framework before and need some days to figure out Sinon and the right usage of Mocks, Stubs and Spies. I am also looking into the other tests to do it similar like you have done - but the controller.root I will put into a separate test file (could be moved later).

Of cause I will squash the commits like @LinusU taught me
🎓
:octocat:
... give me some days - then I will make a pull request after squashing commits.

@Student007
Copy link
Member

DONE 😄
#290

@Frijol
Copy link
Member Author

Frijol commented Oct 23, 2015

Updated to #307

@johnnyman727
Copy link
Contributor

Closed with #453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants