T2 root

[Student007]

Purpose

This pull request will add the t2 root command to the t2-cli.

Side effects

• test/unit/deploy.js: console.log('testing deploy') // due to frequently linter bleating
• same in test/common/tessel-classic.js
• changes of test/unit/provision.js are caused by automatic linter activities ...
• test/unit/usb_connection.js is changed due to changes in lib/usb_connection.js (err -> warn)

New Files

• lib/root_controller.js

Everything else is located in bin/controller.js

New Test files

• test/unit/menu.js -> unit tests for Menu creation
• test/unit/seekTessels.js -> unit tests for seeking Tessels with root command
• test/unit/root.js -> root ssh without menu (single Tessel found)

Note: Tests run successfully on all reference machines (Mac OS X Yosemite, Windows 7 Professional, Ubuntu 14.04)

Fixme

There is no handler for managing a ssh-connected Tessel is powering off ! Needs to be fixed within the firmware if necessary... (Terminal freezes imediatelly after poweroff the (virtual) Tessel)

Improvements

The style of the menu needs a little bit love. It is reduced to functional working mode due to expectation it maybe would be replaced by a more complex and useful terminal-menu what is also providing realtime data of Tessels are found.

Usabiliy

Due to some mistakes I did during my journey/while learning curve .... there are some feedbacks/tips and a debug mode:

• netmask is the limit
• network topology could cause a single Tessel is found twice (this should be added to the list cmd also)

TODO

Because I do not own at least one Tessel 2 ... I am not able to check how it works with multiple physical Tessels 😿

[rwaldron]

@johnnyman727 eventually we're going to need to put these icky strings into template files and load them in at runtime

[johnnyman727]

@Student007 there is no need to add the usage function here. nomnom takes care of it for you as long as you add help tags to all the parameters. Check out the other commands for an example.

@rwaldron ugh agreed!

[Student007]

The problem is, it would write Usage: node t2 root instead of t2 root - I like the idea of templates.
@Frijol it looks like you are figuring out some things at #274 - is there also a general way to fix the node t2 root problem ?

[Frijol]

If I have:

parser.command('root')
  .option('path', {
    abbr: 'i',
    full: 'path',
    metavar: 'PATH',
    default: '~/.tessel/id_rsa',
    help: 'Private Key (Note: created by "t2 key generate")'
  })
  .callback(function(opts) {
    controller.root(opts)
      .then(closeSuccessfulCommand, closeFailedCommand);
  })
  .help('Gain SSH root access to one of your authorized tessels (menu listing if multiple targets)');

I get:

➜  t2-cli git:(t2-root) ✗ t2 root -h

Usage: /usr/local/bin/iojs t2 root [options]

Options:
   -i PATH, --path PATH   Private Key (Note: created by "t2 key generate")  [~/.tessel/id_rsa]

Gain SSH root access to one of your authorized tessels (menu listing if multiple targets)

What's the issue? You want to get rid of /usr/local/bin/iojs part?

[Student007]

@Frijol yes 😄

[Student007]

what would be a new issue / contribution task

[Frijol]

Ah, I see. Yeah, that should be a separate issue. Good idea. A brief look through nomnom.js doesn't reveal a solution.

[Student007]

(I couldn't find a provided solution in nomnom.js ... also reading code ... did this before some weeks)

[johnnyman727]

@Student007 what do you think about leaving the usage string our for this PR and then we'll make a separate PR that grabs all strings from a template file. I'd rather keep them all consistent at any one time so that it's more straightforward for new contributors.

[Student007]

since 6 days Nomnom is deprecated !

I've figured out ... and created a pull request:
#310
The reason I though it doesn't work was to use the "script" part on on the wrong object level.

[johnnyman727]

@Student007 should we close this PR in favor of #307?

[johnnyman727]

Closing in favor of reviewing #307 and various other PRs this was broken into.