Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "t2-progress" which is a throwaway fork of "progress" that applies the patch to terminate. Fixes gh-1073 #1077

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Use "t2-progress" which is a throwaway fork of "progress" that applies the patch to terminate. Fixes gh-1073 #1077

merged 1 commit into from
Nov 4, 2016

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Nov 2, 2016

@tcr @HipsterBrown I've forked "node-progress" into "t2-progress" (with a bunch of nasty warnings), applied the patch necessary to fix the issue and published to npm. No new tests, because its the same usage on our end.

@coveralls
Copy link

coveralls commented Nov 2, 2016 •
edited

Coverage Status

Coverage remained the same at 74.941% when pulling 3b3740e on 1073 into fb394d5 on master.

@coveralls
Copy link

coveralls commented Nov 2, 2016 •
edited

Coverage Status

Coverage remained the same at 74.941% when pulling 3b3740e on 1073 into fb394d5 on master.

@rwaldron
Use "t2-progress" which is a throwaway fork of "progress" that applie…
486c986 
…s the patch to terminate. Fixes gh-1073, Fixes gh-1044

Note: this is the same thing as we did with npmlog. When/if the relevant patch is merged to the official node-progress module, we'll drop this and restore that module as a dependency.
@HipsterBrown
Copy link
Contributor

Hoping your patch gets resolved by node-progress but thank you for the temporary solution in the meantime. LGTM 👍

@rwaldron
Copy link
Contributor Author

rwaldron commented Nov 3, 2016

Will merge when this is green

@rwaldron
Copy link
Contributor Author

rwaldron commented Nov 3, 2016

Thanks @HipsterBrown

@coveralls
Copy link

coveralls commented Nov 3, 2016 •
edited

Coverage Status

Coverage remained the same at 74.941% when pulling 486c986 on 1073 into fb394d5 on master.

@rwaldron rwaldron merged commit 6882ebc into master Nov 4, 2016
@Frijol Frijol deleted the 1073 branch July 7, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwaldron @coveralls @HipsterBrown