adding check to make sure d exists before trimming, #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stops spinner while interactivity initing to keep it from loading over text
1 similar comment
rwaldron
reviewed
Nov 14, 2016
| @@ -49,6 +49,9 @@ exportables.buildJSON = (npmConfig) => { | |||
| promzardConfig = path.join(resources, 'init-config.js'); | |||
| } | |||
|
|
|||
| // Stop spinner from being in our way while entering package.json data | |||
| log.spinner.stop(); | |||
|
Since the init operations still have relatively low coverage, I don't think the coverage decrease should block this. There is also no clear way to add a simple test for this (which is actually due to the previous statement). |
|
Sweet. Thank you. I thought I left a comment asking if there was any test to add but I guess I never added it. Thanks again. |
|
No worries, I'm going to write some basic tests for this and push them up shortly. This way you can observe and have a good idea for next time :) |
|
Oh, actually... I have a better idea. I will add basic tests that should've existed and then you can make a PR that adds assertions for the changes! |
|
sounds great to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stops spinner while interactivity initing to keep it from loading over text
fixes #771