Commands: support memory info request. Fixes gh-388 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,6 +171,11 @@ makeCommand('wifi') | |||
| }) | |||
| .help('Configure the wireless connection'); | |||
|
|
|||
| makeCommand('memory') | |||
There was a problem hiding this comment.
Do we need to make this accessible to the user? It should hopefully rarely come up so I'd shy away from adding more commands.
There was a problem hiding this comment.
No, but I figured for your testing purposes it would be useful.
|
Comments added. It mostly looks good but I don't think we should make this functionality command line accessible, just easy to use by other functions in the CLI. It should rarely come up for users and the output is hard to parse as a human anyway. |
WFM. |
|
@johnnyman727 updated according to review notes! |
|
Looks fantastic! Feel free to merge. |
rwaldron
added a commit
that referenced
this pull request
Oct 22, 2015
Commands: support memory info request. Fixes gh-388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information contained within the result can be used to implement the checks described in #382