root: tests #454
Merged
root: tests #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| }; | ||
| } | ||
|
|
||
| S.prototype = Object.create(Emitter.prototype); |
There was a problem hiding this comment.
I've always wondered how to assign the Emitter properties to a single object instance!
|
@rwaldron thanks for putting this together. I got started on tests but didn't get far so this was very useful. |
|
|
||
| var opts = {}; | ||
|
|
||
| controller.root(opts) |
There was a problem hiding this comment.
I'm a little surprised root doesn't reject because standardTesselCommand doesn't return a Tessel.
There was a problem hiding this comment.
Oh I see - because standardTesselCommand returns Promise.resolve (instead of an unfulfilled promise), the whole root procedure finishes up before it gets to the shell part.
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.