New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of option 'password' should be string #646

Merged

rwaldron merged 1 commit into tessel:master from taimos:feature/fixWifiPassword

Apr 9, 2016

Contributor

hoegertn commented Apr 9, 2016

When your wifi password contains only numbers and is long the cli converts it to a number with exponential representation. This breaks the configuration.

$ t2 wifi -n MySSID -p 432565XXXXXXXXXXXXXXXXXXXXXXXXXXXXX8743
INFO Looking for your Tessel...
INFO Connected to Tessel.
INFO Wifi Enabled.
INFO Wifi Connected. SSID: MySSID, password: 4.32565XXXXXXXXXXXXX+39, security: psk2


          fix type of wifi password

361c00b

Contributor

rwaldron commented Apr 9, 2016

Great catch!

rwaldron merged commit fc24618 into tessel:master

hoegertn deleted the feature/fixWifiPassword branch

April 9, 2016 22:58

Contributor

rwaldron commented Apr 9, 2016

I'm trying to write a test for this and the test revealed that even with the type: "string" set, the value is being coerced into a number with an exponent part.

Contributor Author

hoegertn commented Apr 9, 2016

it worked on the cli. I was able to connect my wifi

Contributor

rwaldron commented Apr 9, 2016

I assumed that was the case—I didn't think you'd make the patch otherwise ;)

Contributor

rwaldron commented Apr 9, 2016

I'll worry about tests later, this stays in.

tikurahul pushed a commit to tikurahul/t2-cli that referenced this pull request


          fix type of wifi password (tessel#646)

90b426b

Contributor

rwaldron commented Apr 11, 2016

@hoegertn I totally forgot to make sure that you had signed the CLA. If you haven't done so, please do that here: http://dojofoundation.org/about/claForm

Contributor Author

hoegertn commented Apr 11, 2016

done

Contributor

rwaldron commented Apr 11, 2016

Brilliant! Thank you kindly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment