Build the start script path correctly on Windows

[jendib]

Linked to https://forums.tessel.io/t/tessel-2-does-not-start-my-application-with-push/2329/3

[johnnyman727]

@jendib thanks for taking the initiative to fix this.

Could you explain why the path.join method doesn't work on Windows? What path does it create? I was under the impression that the purpose of path.join was to abstract different file system implementations across platforms.

[jendib]

Yes path.join indeed abstract the host FS, however in this case, we don't want this. We want to create the path to the init script used to launch the node app when Tessel is starting. So we need to build a unix path.
Before, this line does this: \app\start
And after: /app/start

[rwaldron]

@johnnyman727 this is correct, for the same reason as: 50732a7 I'll spend some time today checking for anymore mistakes like this

@jendib two things:

• based on the commit I linked above, do you think you can write a test for this change? If you need help, ping me here or on slack—I'd be happy to help get you started
• If you haven't done so already, please sign the CLA: http://dojofoundation.org/about/claForm

[rwaldron]

@jendib and I discussed a strategy for tests, all that remains now:

• @jendib signs CLA (or just confirm that it's already signed)
• @jendib merges https://github.com/jendib/t2-cli/pull/1

Once those are complete, and this PR is green, then it's +1 to merge

[jendib]

It's merged and I signed the CLA, thanks @rwaldron !

[brunohunziker]

Could somebody make a new relaease containing the change?

[LinusU]

You could change this into path.posix.join(...) instead

[jendib]

Will do, thanks!