Test fixes #718
Merged
Test fixes #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
force-pushed
the
ci-node-5-provision-tests
branch
from
f1f8a0b
to
ec7717d
Compare
|
|
||
| MockRSA.prototype.exportKey = function() {}; | ||
|
|
||
| module.exports = global.IS_TEST_ENV ? MockRSA : require('node-rsa'); |
There was a problem hiding this comment.
This allows us to mock RSA key creation in the tests. Previously, new NodeRSA(...) was the longest running operation in the test suite, and was run several times by the provision and key tests
rwaldron
force-pushed
the
ci-node-5-provision-tests
branch
from
ec7717d
to
c6c9e45
Compare
|
Note that the run time I included above is 6838ms. I just ran on master and it took 33224ms. |
- don't use NodeRSA in tests - stub fs operations whenever possible - stub public key operations whenever possible - interval until activeSeeker is available Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron
force-pushed
the
ci-node-5-provision-tests
branch
from
c6c9e45
to
288dd14
Compare
|
I'm still working on that appveyor nonsense |
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron
force-pushed
the
ci-node-5-provision-tests
branch
from
33ea67f
to
35146a1
Compare
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron
force-pushed
the
ci-node-5-provision-tests
branch
from
b2c57a2
to
d762c60
Compare
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complete run should look like:
Specifically, it ends with 1065 assertions
Signed-off-by: Rick Waldron waldron.rick@gmail.com