t2 run/push: built-in whitelist rules should have node_modules/** prefix to ensure they are found at any installation depth below node_modules/

[rwaldron]

Issue appears when using npm 3

Signed-off-by: Rick Waldron waldron.rick@gmail.com

[HipsterBrown]

Would a good smoke test be to run the socket-io example app using npm 3?

[rwaldron]

Yeah, definitely

[rwaldron]

@HipsterBrown have you had a chance to smoke test?

[HipsterBrown]

@rwaldron Not yet. But I am planning to do that this afternoon.

[HipsterBrown]

Smoke Test:

Went through this socket-io example app test using npm 3.

Got the following output:

Nicks-MacBook-Pro:chat-example hipsterbrown$ t2 run index.js
INFO Looking for your Tessel...
INFO Connected to tessel-router.
INFO Building project.
WARN Pre-compiled module is missing: ws.
This might be caused by any of the following:

1. The binary is platform specific and cannot be compiled for OpenWRT.
2. A pre-compiled binary has not yet been generated for this module.
3. The binary didn't compile correctly for the platform that you're developing on.
    It's possible that the binary is Linux-only or even OpenWRT specific,
    try npm installing with "--force" and rerun your deployment command.

Please file an issue at https://github.com/tessel/t2-cli/issues/new
INFO Writing project to RAM on tessel-router (958.464 kB)...
INFO Deployed.
INFO Running index.js...
listening on *:3000

Successful deploy! 👍

LGTM

[rwaldron]

What the hell is that ws message?

[HipsterBrown]

Is there a compiled binary for ws for Tessel?

[rwaldron]

¯_(ツ)_/¯

+ pre-gypify --package_name '{name}-{version}-{configuration}.tgz'
/home/vagrant/.nvm/versions/node/v4.4.3/lib/node_modules/pre-gypify/pre-gypify.js:8
  var targetName = data.targets.filter(function (target) {
                       ^

TypeError: Cannot read property 'targets' of undefined
    at /home/vagrant/.nvm/versions/node/v4.4.3/lib/node_modules/pre-gypify/pre-gypify.js:8:24
    at Socket.finish (/home/vagrant/.nvm/versions/node/v4.4.3/lib/node_modules/pre-gypify/node_modules/gyp-reader/gyp-reader.js:35:14)
    at emitNone (events.js:72:20)
    at Socket.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:913:12)
    at nextTickCallbackWith2Args (node.js:442:9)
    at process._tickCallback (node.js:356:17)
Connection to 127.0.0.1 closed.

[HipsterBrown]

@rwaldron So as far as I can tell from searching the engine.io repo, ws is set as a dependency but only used in testing. Reference search

[rwaldron]

@HipsterBrown thanks!