Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deployment from entry point without package.json in directory. Fixes gh-717 #766

Merged
merged 1 commit into from
Jun 11, 2016

Conversation

rwaldron
Copy link
Contributor

Smoke Test

mkdir t2-no-package.json && cd t2-no-package.json;
t2 init;
rm {package.json,.tesselinclude};
ls -ah;
t2 run index.js;

Observed:

rwaldron at nova in ~/robotz
$ mkdir t2-no-package.json && cd t2-no-package.json;
rwaldron at nova in ~/robotz/t2-no-package.json
$ t2 init;
Initializing Tessel 2 Project...
Created package.json.
Created .tesselinclude.
Wrote "Hello World" to index.js
rwaldron at nova in ~/robotz/t2-no-package.json
$ rm {package.json,.tesselinclude};
rwaldron at nova in ~/robotz/t2-no-package.json
$ ls -ah;
.
└── [-rw-r--r-- rwaldron staff     287 Jun 10 17:51]  index.js

0 directories, 1 file
rwaldron at nova in ~/robotz/t2-no-package.json
$ t2 run index.js;
INFO Looking for your Tessel...
INFO Connected to Tessel-02A347EF35F2.
INFO Building project.
INFO Writing project to RAM on Tessel-02A347EF35F2 (3.072 kB)...
INFO Deployed.
INFO Running index.js...
I'm blinking! (Press CTRL + C to stop)

Expected Outcome

A new project is created, the package.json and .tesselinclude are deleted (the latter is not necessary), the index is deployed without failing to find a package.json

cc @HipsterBrown

Signed-off-by: Rick Waldron waldron.rick@gmail.com

…ixes tesselgh-717

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
(cherry picked from commit 9b63768)
@HipsterBrown
Copy link
Contributor

Rad! I'll try this out tonight or tomorrow.

@HipsterBrown
Copy link
Contributor

Did the smoke test with the following output:

Nicks-MacBook-Pro:t2-no-package.json hipsterbrown$ ls -ah;
.       ..      index.js
Nicks-MacBook-Pro:t2-no-package.json hipsterbrown$ t2 run index.js
INFO Looking for your Tessel...
INFO Connected to j5.
INFO Building project.
INFO Writing project to RAM on j5 (3.072 kB)...
INFO Deployed.
INFO Running index.js...
I'm blinking! (Press CTRL + C to stop)
^CNicks-MacBook-Pro:t2-no-package.json hipsterbrown$

Success! LGTM 👍

@rwaldron rwaldron merged commit 765ad93 into tessel:master Jun 11, 2016
@rwaldron
Copy link
Contributor Author

Thanks for the review @HipsterBrown!

@rwaldron rwaldron deleted the 717 branch June 11, 2016 19:12
rwaldron added a commit to rwaldron/t2-cli that referenced this pull request Jun 13, 2016
…ixes tesselgh-717 (tessel#766)

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
(cherry picked from commit 9b63768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants