t2 init: broad cleanup #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
force-pushed
the
init-cleanup
branch
2 times, most recently
from
e1a36f7
to
17c1216
Compare
| controller.installDrivers = function() { | ||
| return drivers.install(); | ||
| }; | ||
|
|
There was a problem hiding this comment.
This is just being moved to lib/controller.js
| @@ -33,14 +31,14 @@ exportables.loadNpm = () => { | |||
| }; | |||
|
|
|||
| // Resolve an npm cofig list, or nothing (existance is not needed) | |||
| exportables.getNpmConfig = (npm) => { | |||
| exportables.resolveNpmConfig = (npm) => { | |||
There was a problem hiding this comment.
In general, I think things that are "resolved" by a promise should be named accordingly.
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
| } | ||
| // Copy over config file, the blinky main, and the toml file | ||
| fs.createReadStream(path.resolve(__dirname, './../../resources/rust/', file_toml)).pipe(fs.createWriteStream(path_toml)); | ||
| fs.createReadStream(path.resolve(__dirname, './../../resources/rust/', cargoToml)).pipe(fs.createWriteStream(cargoTomlDir)); |
There was a problem hiding this comment.
Could this be simplified to use fs.copy or fs.copySync is we want to keep it synchronous, like in javascript.js?
There was a problem hiding this comment.
Yes, you're right. Revision to follow
… string Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
| log.info(`Wrote "Hello World" to ${dirAndMainRs}`); | ||
| resolve(); | ||
| }); | ||
| }); |
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
|
Awesome. Thanks for tackling this @rwaldron. Once tests pass LGTM 👍 |
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
|
Thanks @HipsterBrown! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. I still have more JS tests to write.
Signed-off-by: Rick Waldron waldron.rick@gmail.com