Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code compression optional, default to —compress=true. Fixes gh-776 #801

Merged
merged 1 commit into from
Jul 20, 2016
Merged

Make code compression optional, default to —compress=true. Fixes gh-776 #801

merged 1 commit into from
Jul 20, 2016

Conversation

rwaldron
Copy link
Contributor

  • t2 run <index.js> --compress=false will skip the code compression step

@huseyinkozan sorry for the delay on this

@HipsterBrown @carlbaron review?

Smoke Test

  1. Create a new project: mkdir t2-776 && cd t2-776 && t2 init
  2. Run: t2 run index.js --compress=false
  3. Once it's loaded and running, open a separate terminal and run: t2 root
  4. Once you are SSH'ed to the board, run: cd /tmp/remote-scripts/ && cat index.js. The content should be the same as it appears in your local project directory.

Signed-off-by: Rick Waldron waldron.rick@gmail.com

HipsterBrown
HipsterBrown reviewed Jul 18, 2016
View reviewed changes
test/unit/deployment/javascript.js
compress: false,
slim: true,
}).then(bundle => {
extract(bundle, (error, entries) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is causing an linter error.

@HipsterBrown
Copy link
Contributor

HipsterBrown commented Jul 18, 2016 •
edited

The code looks good to me (after the linter error is fixed). 👍 I can do a smoke test tonight but I'm fairly confident this is good to go.

@rwaldron
Copy link
Contributor Author

Strange... those lines don't match the code I'm looking at locally...

@HipsterBrown HipsterBrown mentioned this pull request Jul 19, 2016
Open
@HipsterBrown
Copy link
Contributor

Smoke test worked as it should. Also opened up a quick PR to this branch to fix that jshint error -> rwaldron#2

@huseyinkozan
Copy link

@rwaldron No problem.
Thanks for the feature.
Will this disable compression for all .js files (includes node_modules/__/.js), or only user files ?

@rwaldron
Copy link
Contributor Author

Will this disable compression for all .js files (includes node_modules//.js), or only user files ?

Yes, it will completely bypass the compression.

@rwaldron
Make code compression optional, default to —compress=true. Fixes tess…
fa728d3 
…elgh-776

- `t2 run <index.js> --compress=false` will skip the code compression step

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
@huseyinkozan
Copy link

Thanks @rwaldron.

@rwaldron rwaldron merged commit 08e790a into tessel:master Jul 20, 2016
@rwaldron
Copy link
Contributor Author

Thanks for the review, this will be in the release today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwaldron @HipsterBrown @huseyinkozan