Dedupe Tessels found on LAN connections. Fixes gh-719 #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good to me. Great addition to the tests as well. I can smoke test this tonight if needed. I appreciate the screenshots for previewing the issue and solution. |
The problem here was: 1. Nothing was actually being put into `this.discovered` 2. Even if there had been, the test we did have would've passed anyway because it just put a number in the list and then emitted a number. That would assume that the thing put into `this.discovered` had the same object identity as the thing being checked, which is wrong. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
|
Smoke test results: Tried it a couple times and always got the same result. 👍 |
|
Looks good to me. Have only 1 Tessel so couldn't easily smoke test it. 👍 |
|
Again, I appreciate the reviews and smoke tests where possible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here was:
this.discoveredthis.discoveredhad the same object identity as the thing being checked, which is wrong.Smoke Test
This is easier to do with 2 or more Tessels, so I've just taken screen shots to show the result of the changes:
Before:
After:
Signed-off-by: Rick Waldron waldron.rick@gmail.com