Fix-bricked-restore #826
Merged
Fix-bricked-restore #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -220,7 +220,11 @@ exportables.flash = function(tessel, buffers) { | |||
| buffers.partition = exportables.partition(mac1, mac2); | |||
|
|
|||
| return Promise.resolve().then(() => { | |||
| log.info('Bulk Erasing Flash Memory...'); | |||
| log.info('Setting WRITE_ENABLED'); | |||
There was a problem hiding this comment.
Maybe if there had been a log statement it wouldn't have been missed when refactoring ;)
Kidding aside, thanks for the merge. Looking forward to contributing.
rwaldron
added a commit
that referenced
this pull request
Aug 22, 2016
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During refactor,
exportables.enableWritewas defined but never called. Also make sure to wait for memory to be erased before writing.fixes #824