Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bail out if not a valid version of node. Fixes gh-764 #829

Merged
merged 1 commit into from Aug 22, 2016

Conversation

rwaldron
Copy link
Contributor

Sure, this is incredibly brutal, but the usb module DOESN'T WORK on Node.js > 4, so there is no point in being misleading. This is "fail hard, fail early" at it's bluntest.

cc @HipsterBrown

Signed-off-by: Rick Waldron waldron.rick@gmail.com

Sure, this is incredibly brutal, but the usb module DOESN'T WORK on Node.js > 4, so there is no point in being misleading. This is "fail hard, fail early" at its bluntest.

Related to tesselgh-828

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
@dbuentello
Copy link
Contributor

Very brutal...Im on 6.4.0 and usb works fine

─┬ t2-cli@0.0.25
  ├── acorn@3.3.0
  ├── async@1.5.2
  ├── bindings@1.2.1
  ├── char-spinner@1.0.1
  ├── colors@1.1.2
  ├── common-tags@0.0.1
  ├── fs-extra@0.26.7
  ├── fs-temp@1.1.0
  ├── fstream@1.0.10
  ├── fstream-ignore@1.0.5
  ├── glob@5.0.15
  ├── inquirer@0.8.5
  ├── is-root@1.0.0
  ├── mdns-js@0.4.0
  ├── minimatch@3.0.3
  ├── node-rsa@0.2.30
  ├── nomnom@1.8.1
  ├── npm@2.15.10
  ├── npmlog@4.0.0
  ├── osenv@0.1.3
  ├── progress@1.1.8
  ├── promzard@0.3.0
  ├── request@2.74.0
  ├── semver@5.3.0
  ├── shell-escape@0.2.0
  ├── ssh2@0.4.15
  ├── sshpk@1.9.2
  ├── stream-to-buffer@0.1.0
  ├── t2-project@0.4.0
  ├── tar@2.2.1
  ├── tar-stream@1.5.2
  ├── toml@2.3.0
  ├── uglify-js@2.7.3
  ├── update-notifier@0.6.3
  ├── url-join@0.0.1
  ├── usb@1.1.2
  └── usb-daemon-parser@0.0.2

@dbuentello
Copy link
Contributor

i do remember getting warning on install but didnt look into them since it seemed to still work. Will uninstall/reinstall and report results

@HipsterBrown
Copy link
Contributor

Will smoke test tonight.

@HipsterBrown
Copy link
Contributor

Works as advertised. 👍 Good to merge as soon as Travis passes.

@HipsterBrown HipsterBrown merged commit ced1f07 into tessel:master Aug 22, 2016
@rwaldron
Copy link
Contributor Author

@dbuentello this is really only temporary until we get Node 6 sorted for node-usb

@rwaldron
Copy link
Contributor Author

Still failing to install correctly on Node 6 (due to node-usb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants