Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operating system tabs don't render properly in the Prereqs page #160

Closed
Frijol opened this issue Mar 22, 2017 · 3 comments
Closed

Operating system tabs don't render properly in the Prereqs page #160

Frijol opened this issue Mar 22, 2017 · 3 comments

Comments

@Frijol
Copy link
Member

Frijol commented Mar 22, 2017

The problem:

The page is http://tessel.github.io/t2-start/cmd.html

It looks like this:

screen shot 2017-03-22 at 12 57 28 pm

It should look and work the way it does on the Install page:

screen shot 2017-03-22 at 12 59 36 pm

To resolve this issue:

From the files in https://github.com/tessel/t2-start

Find out what's different between the tabs in cmd.md and install.md.

Use the tabs on install.md as a model to fix the tabs on cmd.md.

(Hint: clone this repo and then follow these instructions to render the pages locally)

@Frijol Frijol changed the title Beginner contribution: Operating system tabs don't render properly in the Prereqs page Operating system tabs don't render properly in the Prereqs page Mar 26, 2017
@yousifm
Copy link

yousifm commented Apr 15, 2017

It seems to render correctly when viewed using jekyll on my local clone

@rickMcGavin
Copy link

@Frijol It definitely displays correctly on the local server. I tried pushing it to my own repo, and it displays incorrectly like in the repo here. I'm not seeing any difference between install.md and cmd.md that's causing the issue.

I believe I did find the problem though. I analyzed the network requests in chrome dev tools. The issue seems to be that the install.js script isn't running when the cmd.html file loads on gh-pages, but it does load the install.js script on the local jekyll server.

I believe this is further supported when you inspect the <dl> element locally, the nested tabs have been converted to <dd> elements. On gh-pages, they are <a> tags wrapped in a <p> tag as if the script never ran to convert them.

I cannot seem to figure out how to fix it so the install.js script runs when you load cmd.html on gh-pages though.

@reuben453
Copy link
Contributor

For some reason the install.js script does not get included on the page when the script tag is placed in cmd.html. I moved it to the markdown file (cmd.md) and it now gets included. I also changed the dl element to be formed using kramdown syntax rather than html and text.

I've opened a PR for these changes: #162
Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants