Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused function PrepareDistortedPix() #1052

Closed
amitdo opened this issue Jul 24, 2017 · 6 comments · Fixed by #2259
Closed

Unused function PrepareDistortedPix() #1052

amitdo opened this issue Jul 24, 2017 · 6 comments · Fixed by #2259

Comments

@amitdo
Copy link
Collaborator

amitdo commented Jul 24, 2017

@theraysmith,

The new (c1c1e42) function PrepareDistortedPix() in training/degradeimage.h is not being used currently.
https://github.com/tesseract-ocr/tesseract/blob/4efc539f512bf/training/degradeimage.h#L38

Are you going to fix that?

@amitdo
Copy link
Collaborator Author

amitdo commented Aug 3, 2017

@theraysmith

Another try... hope you'll notice. Please read my above message (at !#1052).

Please also see #1024

@theraysmith
Copy link
Contributor

It is used internally at Google.
Text2image could be modified to use it too.

@Shreeshrii
Copy link
Collaborator

Text2image could be modified to use it too.

That would be great. This is what I referred to in - tesseract-ocr/tessdata#69 (comment)

@Shreeshrii
Copy link
Collaborator

Please see #2221
That gives an indication that this function might have been used while training the _fast models.

@stweil Can this or parts of it be added to the currently used degradeimage function?

@amitdo
Copy link
Collaborator Author

amitdo commented Feb 14, 2019

if (invert && randomizer->SignedRand(1.0) < 0)
pixInvert(distorted, distorted);

@Shreeshrii
Copy link
Collaborator

Partial implementation via #2259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants