Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent ABI change in 3.04.x #254

Closed
innir opened this issue Mar 7, 2016 · 6 comments
Closed

Silent ABI change in 3.04.x #254

innir opened this issue Mar 7, 2016 · 6 comments

Comments

@innir
Copy link
Contributor

innir commented Mar 7, 2016

Hi,

if seems, that moving PageIterator* AnalyseLayout() to api/baseapi.h[1] causes a silent ABI breakage. Could you please move it back to api/baseapi.cpp? Please see the corresponding Debian bugs for reference [2], [3].
I could prepare a PR if you prefer.

Thanks,
Philip

[1] https://github.com/tesseract-ocr/tesseract/blob/master/api/baseapi.h#L500
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=816857
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815056#24

@jbreiden
Copy link
Contributor

jbreiden commented Mar 7, 2016

@zdenop
Copy link
Contributor

zdenop commented Mar 8, 2016

Please create PR. Thanks.

@innir
Copy link
Contributor Author

innir commented Mar 8, 2016

Here you go: PR #259

@zdenop zdenop closed this as completed in 7461b61 Mar 8, 2016
zdenop added a commit that referenced this issue Mar 8, 2016
Fix ABI break introduced in 3.04.00, fixes #254
@zdenop
Copy link
Contributor

zdenop commented Mar 8, 2016

thanks.

@jbreiden
Copy link
Contributor

jbreiden commented Mar 8, 2016

Please make sure this reaches the 3.04 branch.

@zdenop
Copy link
Contributor

zdenop commented Mar 8, 2016

done.

Zdenko

On Tue, Mar 8, 2016 at 5:03 PM, jbreiden notifications@github.com wrote:

Please make sure this reaches the 3.04 branch.


Reply to this email directly or view it on GitHub
#254 (comment)
.

zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
zvezdochiot pushed a commit to ImageProcessing-ElectronicPublications/tesseract that referenced this issue Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants