Improve snap packaging #1892
Merged
Improve snap packaging #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapcraft supports automatic `git describe` based versioning when the `version` key is set to `git`. This gives more information of the source status of a snap distribution. Refer-to: Snapcraft.yaml reference - doc - snapcraft.io <https://forum.snapcraft.io/t/snapcraft-yaml-reference/4276> Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
This change allows downstream packagers to publish the snap to the candidate and stable channels. Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
This allows cleaner diffs for future modifications using the YAML's "folded" block scalar style. Refer-to: Folded Style - Block Scalar Styles - Block Styles <http://yaml.org/spec/1.2/spec.html#id2796251> Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
This allows access to the files under `/media/*` and `/run/media/*`, as the connection is not automatic connect instructions is also added to the snap's description. Refer-to: Interfaces - doc - snapcraft.io <https://forum.snapcraft.io/t/interfaces/6154> Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Snapcraft will soonly drop the feature to automatic staging the depending libraries into the snap, specify it manually to avoid breakage in the future. This deals with the following warning message in the build: ``` Priming leptonica Files from the build host were migrated into the snap to satisfy dependencies that would otherwise not be met. This feature will be removed in a future release. If these libraries are needed in the final snap, ensure that the following are either satisfied by a stage-packages entry or through a part: usr/lib/x86_64-linux-gnu/libjbig.so.0 usr/lib/x86_64-linux-gnu/libjpeg.so.8 usr/lib/x86_64-linux-gnu/libopenjp2.so.7 usr/lib/x86_64-linux-gnu/libtiff.so.5 Priming tesseract Files from the build host were migrated into the snap to satisfy dependencies that would otherwise not be met. This feature will be removed in a future release. If these libraries are needed in the final snap, ensure that the following are either satisfied by a stage-packages entry or through a part: usr/lib/x86_64-linux-gnu/libgomp.so.1 ``` Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
|
The c-i build result doesn't seem to be the result of this PR, just saying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues regarding the snap packaging.
Conforming-to: tesseract/CONTRIBUTING.md at master · tesseract-ocr/tesseract https://github.com/tesseract-ocr/tesseract/blob/master/CONTRIBUTING.md
Signed-off-by: 林博仁(Buo-ren, Lin) Buo.Ren.Lin@gmail.com