src/arch/simddetect.cpp: fix NEON detection on FreeBSD #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
requested changes
Apr 2, 2022
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 3, 2022
Tesseract requires the <asm/hwcap.h> header to detect the availability of NEON instructions on armv7. This commit adds a patch to use the appropriate FreeBSD interface for this purpose. This issue has already been reported to up stream. See also: tesseract-ocr/tesseract#3782 See also: PR #263003 PR: 263004 Approved by: portmgr (build fix blanket)
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 3, 2022
The bundled version of tesseract requires the <asm/hwcap.h> header to detect the availability of NEON instructions on armv7. This issue has already been reported to up stream. Reported upstream: tesseract-ocr/tesseract#3782 PR: 263003 Approved by: portmgr (build fix blanket)
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 3, 2022
The bundled version of tesseract requires the <asm/hwcap.h> header to detect the availability of NEON instructions on armv7. This issue has already been reported to up stream. Reported upstream: tesseract-ocr/tesseract#3782 PR: 263003 Approved by: portmgr (build fix blanket) (cherry picked from commit 16f0acb)
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 3, 2022
Tesseract requires the <asm/hwcap.h> header to detect the availability of NEON instructions on armv7. This commit adds a patch to use the appropriate FreeBSD interface for this purpose. This issue has already been reported to up stream. See also: tesseract-ocr/tesseract#3782 See also: PR #263003 PR: 263004 Approved by: portmgr (build fix blanket) (cherry picked from commit 31efc7f)
stweil
reviewed
May 29, 2022
stweil
reviewed
May 29, 2022
stweil
reviewed
May 29, 2022
stweil
reviewed
May 29, 2022
stweil
reviewed
May 29, 2022
stweil
reviewed
May 29, 2022
|
Please consider opening a code review next time so the system doesn't send me one email for each comment you wrote. |
clausecker
changed the title
stweil
reviewed
May 29, 2022
|
While this pull request was an important fix for ARM hosts, we had a similar severe problem for amd64 / x86_64 host. See issue #3964. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD does not have the
<asm/hwcap>header, requiring some slightly different code to check for NEON availability. This code might also apply to other BSD-like operating systems such as NetBSD, OpenBSD, DragonflyBSD, or iOS, but I haven't checked.