Fixes #4247: remove unnecessary nullptr checks #4248
Conversation
There was a problem hiding this comment.
Thank you. The changes are okay, but I noticed that you did not set your full name in Git (and / or on GitHub). Do you want to fix that before your pull request gets merged?
See https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup if you need instructions how to do that.
Thanks a lot! I have set my full name on Github. |
…inueContext Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
Related report from Coverity Scan: CID 1438675 Dereference after null check. |
| } | ||
| prefix.Set(p, previous->code); | ||
| full_code.Set(p, previous->code); | ||
| previous = previous->prev; |
There was a problem hiding this comment.
I added this statement here because otherwise the for statement would have required a line break.
There was a problem hiding this comment.
I added this statement here because otherwise the for statement would have required a line break.
I think placing previous = previous->prev here or within the for statement is equivalent.
|
Related: Codacy issue #4248. |
See #4247