Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python patches for Feb 2022 update #716

Merged
merged 7 commits into from Feb 22, 2022
Merged

Python patches for Feb 2022 update #716

merged 7 commits into from Feb 22, 2022

Conversation

johnwason
Copy link
Contributor

This pull request contains patches for the Feb 2022 python update.

@johnwason johnwason mentioned this pull request Feb 20, 2022
Merged
@codecov
Copy link

codecov bot commented Feb 20, 2022 •
edited

Codecov Report

Merging #716 (ad05f0e) into master (0112622) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   90.95%   90.96%   +0.01%     
==========================================
  Files         189      189              
  Lines       12641    12637       -4     
==========================================
- Hits        11497    11495       -2     
+ Misses       1144     1142       -2
Impacted Files Coverage Δ
...t_collision/core/contact_managers_plugin_factory.h 100.00% <ø> (ø)
...seract_collision/core/continuous_contact_manager.h 100.00% <ø> (ø)
...esseract_collision/core/discrete_contact_manager.h 100.00% <ø> (ø)
...nclude/tesseract_common/allowed_collision_matrix.h 100.00% <ø> (ø)
tesseract_common/include/tesseract_common/types.h 100.00% <ø> (ø)
...onment/include/tesseract_environment/environment.h 100.00% <ø> (ø)
...act_geometry/include/tesseract_geometry/geometry.h 100.00% <ø> (ø)
...ct_geometry/include/tesseract_geometry/impl/mesh.h 83.78% <ø> (+3.29%) ⬆️
...eometry/include/tesseract_geometry/impl/sdf_mesh.h 100.00% <ø> (ø)
...ude/tesseract_kinematics/core/forward_kinematics.h 100.00% <ø> (ø)
... and 15 more

Levi-Armstrong
Levi-Armstrong reviewed Feb 21, 2022
View reviewed changes
tesseract_geometry/include/tesseract_geometry/geometry.h Outdated
@@ -50,6 +50,7 @@ enum GeometryType
CONVEX_MESH,
SDF_MESH,
OCTREE,
POLYGON_MESH
};
static const std::vector<std::string> GeometryTypeStrings = {
"SPHERE", "CYLINDER", "CAPSULE", "CONE", "BOX", "PLANE", "MESH", "CONVEX_MESH", "SDF_MESH", "OCTREE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also append "POLYGON_MESH"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change.

tesseract_geometry/include/tesseract_geometry/impl/polygon_mesh.h
@@ -201,7 +203,7 @@ class PolygonMesh : public Geometry
*
* @return The vertex normal vector
*/
std::shared_ptr<const tesseract_common::VectorVector3d> getNormals() const { return normals_; }
const std::shared_ptr<const tesseract_common::VectorVector3d>& getNormals() const { return normals_; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why the switch to const&?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWIG wasn't detecting the type properly without const&

@johnwason
Copy link
Contributor Author

I am still cleaning up these patches to fix the CI errors

@Levi-Armstrong
Copy link
Contributor

@johnwason You good with me merging this?

@johnwason
Copy link
Contributor Author

Yeah looks ready

@Levi-Armstrong Levi-Armstrong merged commit 3ddc7ef into tesseract-robotics:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Levi-Armstrong Levi-Armstrong Levi-Armstrong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnwason @Levi-Armstrong