Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find_bullet macro which creates a target to link against #803

Merged

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong
Copy link
Contributor Author

This incorporates PR #801 changes into a macro which creates a target that is used within tesseract.

@johnwason
Copy link
Contributor

Do we need to export the Bullet target? The use of bullet should be self contained.

@Levi-Armstrong
Copy link
Contributor Author

Do we need to export the Bullet target? The use of bullet should be self contained.

This macro is called in the tesseract_collision-config.cmake which handles creation of the target for any package linking against tesseract_collision

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #803 (c8c8b30) into master (ce6d7ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         224      224           
  Lines       13859    13859           
=======================================
  Hits        12506    12506           
  Misses       1353     1353           

@Levi-Armstrong
Copy link
Contributor Author

@johnwason Everything is passing and should provide the same functionality. Let me know what you think.

@johnwason
Copy link
Contributor

I am running a test here: johnwason/tesseract_python-1#2

@johnwason
Copy link
Contributor

Also see microsoft/vcpkg#25784

I added the features double-precision and rtti to the vcpkg bullet package.

Use:

bullet3[double-precision,rtti,multithreading]

with vcpkg to get the required features, once vcpkg completes the merge.

@Levi-Armstrong Levi-Armstrong merged commit dc44522 into tesseract-robotics:master Jul 18, 2022
@Levi-Armstrong Levi-Armstrong deleted the feat/FindBulletMacro branch July 18, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants