Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that the random maximum value of UPnP could not be set #2616

Merged
merged 1 commit into from Apr 14, 2024

Conversation

tesshucom
Copy link
Owner

Problem description

Unable to set the maximum value used for UPnP shuffle list.

image

Steps to reproduce

Set any value and click Save. The value does not change.

System information

  • Jpsonic version: About 2 years and 7 months ago 馃榿

I didn't notice it because I don't touch it much...

Additional notes

There is no particular problem with shuffling, it seems like it is only a problem with the web page. It has been corrected as follows.

  • If null or 0 is specified from the web page, register the default value. Default value is 50.
  • The maximum value that can be specified is 1999. If a higher value is specified, 1999 will be set.
  • Boundary value test added.

@tesshucom tesshucom added type: bug A general bug in: web Issues in web modules (web, webmvc, webflux, websocket) type: degraded Degraded existing functionality labels Apr 14, 2024
@tesshucom tesshucom added this to the jpsonic 114.1 milestone Apr 14, 2024
@tesshucom tesshucom self-assigned this Apr 14, 2024
@tesshucom tesshucom merged commit 1a99ccf into develop Apr 14, 2024
2 checks passed
@tesshucom tesshucom deleted the bugfixes/random-max branch April 14, 2024 04:29
@tesshucom tesshucom mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug type: degraded Degraded existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant