attempt to read ~/.docker/config.json for registry auths #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rough attempt to resolve #261 by reading
~/.docker/config.json
to get auths for an image's registry rather than relying on a singlecreds_file
while not breaking any existing compatibility (by introducing a newdocker_config_auth
flag). I'm sure it's far from perfect, but hoping this is a good jumping off point and folks have better ideas.I realize
image_registry = image.split('/').first
will often be misleading especially for official images on DockerHub, but might be good enough.Looks like there's some similar work in https://github.com/test-kitchen/kitchen-dokken/pull/189/files but not sure 🤷♂️
Issues Resolved
Fixes #261
Check List