Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You broke Chef's Travis CI tests =) #148

Closed
lamont-granquist opened this issue Jun 4, 2015 · 3 comments · Fixed by #151
Closed

You broke Chef's Travis CI tests =) #148

lamont-granquist opened this issue Jun 4, 2015 · 3 comments · Fixed by #151
Assignees
@tyler-ball
Labels
Bug

Comments

@lamont-granquist
Copy link
Contributor

@tyler-ball check out:

https://travis-ci.org/chef/chef/jobs/65344115

After the kitchen-ec2 release yesterday TK started trying to hit the private 172.x IPaddr of the virt rather than the public IP.
@lamont-granquist
Copy link
Contributor Author

About all I can see is 02dc5b4 which by factoring out wait_until_ready() I think you may have lost the side effects which updated the server and hostname variables in the scope of create(state)

@tyler-ball
Copy link
Contributor

Yeah, I can definitely repro this locally - working on a change now

@tyler-ball tyler-ball self-assigned this Jun 4, 2015
tyler-ball added a commit that referenced this issue Jun 4, 2015
@tyler-ball
I introduced a regression where we use an old aws object to fetch con…
8176a57 
…nection information instead of the new object we queried to make sure it is ready, fixes #148
tyler-ball added a commit that referenced this issue Jun 4, 2015
@tyler-ball
I introduced a regression where we use an old aws object to fetch con…
45d31a5 
…nection information instead of the new object we queried to make sure it is ready, fixes #148
@tyler-ball tyler-ball mentioned this issue Jun 4, 2015
Merged
tyler-ball added a commit that referenced this issue Jun 4, 2015
@tyler-ball
I introduced a regression where we use an old aws object to fetch con…
87878bf 
…nection information instead of the new object we queried to make sure it is ready, fixes #148
@scarolan
Copy link
Contributor

scarolan commented Jun 8, 2015

Confirmed, kitchen tries to hit the internal ip address now instead of the public one.

Waiting for SSH service on 172.31.12.37

tyler-ball added a commit that referenced this issue Jun 8, 2015
@tyler-ball
Merge pull request #151 from test-kitchen/tball/more-bugs
f6a3f31 
Query correct instance object for hostname fixes #148
tyler-ball added a commit to chef/chef that referenced this issue Jun 8, 2015
@tyler-ball
Using master of kitchen-ec2 because test-kitchen/kitchen-ec2#148 has …
79266cc 
…been fixed, travis should no longer break
This was referenced Jun 8, 2015
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyler-ball tyler-ball

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Query correct instance object for hostname fixes #148 test-kitchen/kitchen-ec2
3 participants
@scarolan @lamont-granquist @tyler-ball