Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon Linux #321

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Add support for Amazon Linux #321

merged 1 commit into from
Nov 21, 2017

Conversation

ctrlalttaco
Copy link
Contributor

No description provided.

@troyready
Copy link

I haven't done this with the ruby SDK, but here are some notes based on my experience with boto and their image publishing:

  1. It's probably overkill, but I like including the following filters to make sure only relevant AMIs are returned:
[
        {
            'Name': 'name',
            'Values': ['amzn-ami-hvm*x86_64-gp2']
        },
        {
            'Name': 'architecture',
            'Values': ['x86_64']
        },
        {
            'Name': 'root-device-type',
            'Values': ['ebs']
        },
        {
            'Name': 'state',
            'Values': ['available']
        },
        {
            'Name': 'virtualization-type',
            'Values': ['hvm']
        }
]

Need to swap in the specific version in the name, obviously. Not sure if this is too opinionated a search, but I think it might be right.

  1. When I sort the list of images, I'll sometimes end up with RC versions (e.g. amzn-ami-hvm-2017.03.rc-1.20170327-x86_64-gp2 appearing before the actual latest release(e.g. amzn-ami-hvm-2017.03.1.20170617-x86_64-gp2). Not sure if this is a specific to python sorting, but it might be worth explicitly excluding them here too.

  2. When I do boto3.client('ec2').describe_images(), I can specify Owners=['amazon'], which seems a little nicer to me than a specific owner-id. Not sure if that's applicable here or even worth mentioning.

Hope this helps; would love to see this functionality included!

@cheeseplus cheeseplus merged commit 3542809 into test-kitchen:master Nov 21, 2017
@ctrlalttaco ctrlalttaco deleted the add_amazon_linux_platform branch December 4, 2017 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants