Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create multiple instances if "kitchen create" is called multiple t... #46

Merged
merged 1 commit into from
May 1, 2014

Conversation

anl
Copy link
Contributor

@anl anl commented May 1, 2014

...imes.

Calling "kitchen create" multiple times in succession will result in multiple identical instances being launched, with test-kitchen losing track of the earlier instance(s):

$ bundle exec kitchen create
-----> Starting Kitchen (v1.2.1)
-----> Creating <default-ubuntu-1204>...
       EC2 instance <i-80588588> created.
................................       (server ready)
       Waiting for ec2-54-188-228-88.us-west-2.compute.amazonaws.com:22...
       Waiting for ec2-54-188-228-88.us-west-2.compute.amazonaws.com:22...
       Waiting for ec2-54-188-228-88.us-west-2.compute.amazonaws.com:22...
       (ssh ready)\n
       Finished creating <default-ubuntu-1204> (0m58.64s).
-----> Kitchen is finished. (0m59.74s)
$ bundle exec kitchen create
-----> Starting Kitchen (v1.2.1)
-----> Creating <default-ubuntu-1204>...
       EC2 instance <i-76508d7e> created.
...........................       (server ready)
       Waiting for ec2-54-212-23-228.us-west-2.compute.amazonaws.com:22...
       Waiting for ec2-54-212-23-228.us-west-2.compute.amazonaws.com:22...
       (ssh ready)\n
       Finished creating <default-ubuntu-1204> (0m49.24s).
-----> Kitchen is finished. (0m50.36s)

This one-liner should fix that - I first noticed this when writing kitchen-gce, but forgot to send a pull request until now (sorry!); thanks for considering this.

sethvargo added a commit that referenced this pull request May 1, 2014
Don't create multiple instances if "kitchen create" is called multiple t...
@sethvargo sethvargo merged commit d86e36f into test-kitchen:master May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants