Enhancements: Security Group Search & Spot Instance Provisioning #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bdwyertech
commented
Oct 11, 2019
•
bdwyertech
commented
- Search only for Security Groups available to a subnet's VPC
- Support multiple matches for a single search (e.g. an Application tag which spans multiple SG's)
- Stop masking spot instance provisioning errors
- Fixes logic & tests for non-existent subnets & security groups
bdwyertech
force-pushed
the
security-group-vpc-filter
branch
from
dc4ab7c
to
f77e008
Compare
Signed-off-by: Brian Dwyer <brian.dwyer@broadridge.com>
Signed-off-by: Brian Dwyer <brian.dwyer@broadridge.com>
bdwyertech
force-pushed
the
security-group-vpc-filter
branch
from
f77e008
to
0716c87
Compare
bdwyertech
changed the title
Signed-off-by: Brian Dwyer <brian.dwyer@broadridge.com>
bdwyertech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.