Tag on-demand instances at creation time #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
|
After some conversation with @tyler-ball, we think we may be able to use the AWS run_instances() call to tag spot instances at creation time as well. I'm placing this into draft status while I do a rewrite. |
This allows spot instances to be tagged at creation time. The tag-after-create code still needs to be removed, and there is still some refactoring to be done. Also, the ability to use "ondemand" as the spot price is currently broken. Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
tyler-ball
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
1 small update then 
Nice work @clintoncwolfe! This also removes about 2x as many lines as it adds 💪
Co-authored-by: Tyler Ball <tball@chef.io>
|
Way cool. Thanks @clintoncwolfe |
This was referenced Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is started as an adoption of #414 by @sumitag, adding tests and rebasing. #414 applies tags at instance creation time to on-demand instances.
This PR then goes on to convert spot instance requests to use the
create_instances()API call, which allows tagging at creation time. This allows all tagging to happen at creation time, so all post-hoc tagging code is removed.There are some fallout effects from using
create_instances()instead ofspot_instance_request():create_instances()is one-shot, so kitchen-ec2 must explicitly retry the call.There is a feature that allows the user to set the spot price to "on-demand" to get the on-demand price; internally this sets the bid price to an empty string. This is not allowed in theUpdate: When on-demand is specified, the max_price field may simply be omitted, causing the bid price to be set to the on-demand price.create_instances()API. Currently this is not solved, and the feature is broken pending discussion.Issues Resolved
Fixes #360
Fixes #480
Fixes #464
I suggest PRs #364 and #414 be closed.
Check List