Use defaults when creating spot instances - fixes block_duration_minutes #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches back to creating one-time requests and terminate on interrupt, which is the default behavior. THat is needed so that the block_duration_minutes feature will work with the API. The non-default setting swere being used in an attempt to use the valid_until setting, but we are already honoring the spot_wait setting by using it in the retry. Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
|
I have the same problem reported and this version fixes it, please merge if possible Thanks |
|
thank you so much @clintoncwolfe. We are having the same exact issue as the spot instances are being terminated. Looking forward to this merge. |
|
Hi @tyler-ball, would it be possible for you to review and if possible approve the code? We have a problem creating the instances and reserving the time to use them. Thank you very much. |
tyler-ball
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This switches back to creating one-time requests and terminate on
interrupt, which is the default behavior. That is needed so that
the block_duration_minutes feature will work with the API. The
non-default settings were being used in an attempt to use the
valid_until setting, but we are already honoring the spot_wait
setting by using it in the retry.
Issues Resolved
Fixes #511
Check List