Adds support for defining multiple tags for subnet_filter
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure instance is terminated if a failure occurs during creation Adds documentation for specifying multiple tags Signed-off-by: Jared Kauppila <Jared.Kauppila@sentry.com>
|
@jakauppila There's some minor chefstyle issues on the PR |
Signed-off-by: Jared Kauppila <Jared.Kauppila@sentry.com>
|
@tas50 Fixed the couple of issues. Is there a systematic way to tell an IDE to use Chefstyle over Rubocop? Within VSCode I can just configure a workspace override, but it seems like there could/should be something a little more global that follows the repo?
|
|
probably a workstation config in this repo |
kasif-adnan
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
subnet_filterIssues Resolved
#411 #555
List any existing issues this PR resolves
Check List