Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of readiness detection for Windows instances #582

Conversation

jakauppila
Copy link
Contributor

@jakauppila jakauppila commented Apr 13, 2022

Move the fetching of the Windows admin password into the wait_until_ready function to speed up readiness detection of Windows instances

Description

In instances where the administrative username/password is not defined by the user, if we change the Windows instance readiness detection to use the retrieval of the admin password as a readiness factor rather than the console output, we can speed up the readiness detection for Windows instances by 4+ minutes.

In my testing:

  • with a c6i.large, the instance took ~60 seconds to become "ready" (~20 seconds to become "running" and ~40 seconds to retrieve the password)
  • with a t3a.nano, the instance took ~80 seconds to become "ready" (~10 seconds to become "running" and ~70 seconds to retrieve the password)

In contrast to the existing logic:

  • with a c6i.large, the instance took ~310 seconds to become "ready"
  • with a t3a.nano, the instance took ~350 seconds to become "ready"

Issues Resolved

#575

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

…ready` function to speed up readiness detection of Windows instances
@jakauppila
Copy link
Contributor Author

This should be good to go now!

@damacus Looks like there's an issue with the yamllint action: actionshub/yamllint#8

lib/kitchen/driver/ec2.rb Show resolved Hide resolved
@sanjain-progress sanjain-progress merged commit 812076f into test-kitchen:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants